Sean Banko

Results 7 comments of Sean Banko

textinput: placeholder changes component width

@residualmind nice find. Personally, I agree with @Static-Flow that if a placeholder is smaller than the text input, it shouldn't shrink the text input. That seems counter to the notion...

fix: use upstream path in modify response

> Hi @seanbanko can you add a concrete test case? Otherwise I'm sure this will regress Great call. I've added a simple test case to `TestRules` that fails if the...

fix: use upstream path in modify response

@squat just bumping this. Is that test case is sufficient?

fix: use upstream path in modify response

Just taking a look at recent commits, @simonpasquier are you able to review?

fix: use upstream path in modify response

@squat @SuperQ fixed, sorry about that.

fix: use upstream path in modify response

Just following up here. Anything I can do to help get this merged?

fix: use upstream path in modify response

@simonpasquier let me know if I can do anything to help get this over the line!