Sean Perkins

Results 206 comments of Sean Perkins
trafficstars

Tested against v6 and confirmed this issue still exists, only present in Safari. Created a new reproduction (based on the v4 example): https://github.com/sean-perkins/gh-18037-ng-floating-label Reproduction notes: - `.item-has-value` class is not...

Hey @corysmc can you test with this dev-build and let me know if you run into any odd quirks? ```shell npm i @ionic/[email protected] @ionic/[email protected] ``` I tested with the `test-route-modal`...

@puopg this is still an active bug in discovery/development. The issue of dismissing the overlay on route navigation has been resolved in the dev-build, but is also dependent on another...

@philjones88 can you explain the usage behind: ```jsx const TestPage1 = lazy(() => import("./pages/TestPage1")); const TestPage2 = lazy(() => import("./pages/TestPage2")); ``` If I replace that with standard imports: ```jsx import...

Thanks for the follow-up + additional details! Ionic's React routing integration does not currently support the use of `lazy` and likely the handling of suspense as a result. The components...

The commit message is ok here. We will end up squashing the commits anyways, so only the topmost description (the PR title) will matter. I approved CI to run to...

@postnerd merge the latest change from `main` into this branch, run `npm run build` (from the `core` folder) and commit any changes (if any).

Yeah, you can ignore that diff. Running `npm run prettier` from the `/angular` folder will overwrite that change and reformat the file with the current state. I re-triggered CI to...

@postnerd update on our end: The team has drafted and approved a design document around this feature. The only item that is outstanding as a result, is we want to...

Great work here @postnerd 👍 thanks for the contribution!