Sam Abbott

Results 587 comments of Sam Abbott

This all looks pretty spot on. I can look at this this weekend/next week.

In my mind the `get_` functions and friends should be tested and documented in a dataset independent way with dataset tests happening elsewhere. I've updated the title of this issue...

This has got a bit stuck. What do we think still needs doing vs nice to have here?

That sounds like a pretty good standard to go with. @hamishgibbs @kathsherratt what do you think?

Thanks for this @mpadge This sounds great. We have very limited dev capacity at the moment for functionality that we are not directly using but very happy to take PRs

Agree with @ffinger that a two stage dev process makes sense.

Agree on the copy and rename. Sounds like Hadley will not be onboard with our Epi- series 😄 My preference here is `covdata` I think as I see this really...

Damn and they have a badge. Next suggestion: `getcovdata` -> gets at the fact we contain no data and just serve other peoples hard work (which is super important to...

I'd be keen to see an implementation that works with Rstudio server. Usually, everything I do is dockerised so having to install locally just for `rayshader` is a shame. Great...