Sebastián Duque Mesa

Results 14 comments of Sebastián Duque Mesa

I haven't been able to find the root cause of this but it also happens for `r = np.array([1,0,0])` or any other array with more than one zero. Any ideas?

@josh146 @nquesada, is this still relevant knowing that The Walrus does not depend on cython any longer?

@nquesada is this still relevant? Current function signature [here](https://github.com/XanaduAI/thewalrus/blob/cf3f887d316b189a4281dd0c054ee5a2b4efa67a/thewalrus/_hafnian.py#L720-L728)

Hi @changhun0218, thanks for your feature request! This piece of code can indeed be speed up by using numba, let us look into it. If you feel this is something...

Hi @benjaminlanthier! It seems that your tests for the `hafnian_repeated` function are not covering the case in which `A` is close to zero and `loop==False`. ![image](https://user-images.githubusercontent.com/675763/160471152-7fa5c046-7d32-426f-8215-219f8d3e34ed.png) You can look at...

Looking better @benjaminlanthier! 💪 However, it seems that you're still missing a test for the `hafnian_repeated` function where `A` is close to zero and `loop==False`. See line 930 in [here](https://app.codecov.io/gh/XanaduAI/thewalrus/compare/338/tree/thewalrus/_hafnian.py#D1L930).

Hi all, great work! 🚀 Before doing a thorough review, could you please fix the formatting so that the tests passes and fill the PR description?

Please update the description of this PR before merging!

@JQZ1111, no need to create a new PR at all, just ask @benjaminlanthier to modify the description and that's it.

And don't forget to add a new entry to the CHANGELOG file