Sebastian Dröge comments

Results 678 comments of


Sebastian Dröge

gio::Application::get_default() is unsound

Can you actually use an `Application` on a non-default main context?

[FEATURE REQUEST] Mark gio::Icon as Send and Sync

The question is not whether a single implementation of the interface is `Send+Sync` but if all valid implementations of the interface must be `Send+Sync`.

[FEATURE REQUEST] PtrArray has no methods

Personally I would go with the current situation and directly use FFI when these types are needed, and expose them per use-case in a meaningful way in Rust. As there...

ToGlibPtrMove trait and "move" function parameter configuration

This has happened now.

Create tests for glib/src/translate.rs

Please go ahead :)

Create tests for glib/src/translate.rs

> I see a folder called glib/tests, would we make a new file there called something like glib/tests/translate.rs? That's for integration tests. You would put these tests directly into `glib/src/translate.rs`....

Use `&[impl AsRef<str>]` instead of `&[&str]`

This would rather use `impl IntoStrV` now, and that's tracked by another issue already

Support for dynamic types

See https://github.com/gtk-rs/gtk-rs-core/pull/1169

Eq / Hash / etc. for glib::object::WeakRef

Solved by https://github.com/gtk-rs/gtk-rs-core/pull/1006

Use `T: AsRef<str>, &[T]` instead of `&[&str]` in various APIs

At this point this should probably rather make use of `impl IntoStrV`