Sabela
Sabela
Any progress on this? In my case, the validation is correct, although the referenced file does **not** exist (there is typo in the name). ```yaml components: schemas: Treatment: description: blabla...
Regarding the examples ([comment](https://github.com/ga4gh-beacon/specification/issues/254#issuecomment-459703726) in #254), you mean that to be compliant with the spec they can't be null, is this correct? What would be the correct syntax to specify...
Hi @teemukataja. Could you, please, update the beacon.md file with the changes introduced in v1.1.0 and examples of responses from your implementation? Thanks!
PR #279 fixes this.
Hi @mbaudis, I'd keep the `beaconHandover` inside `beaconAlleleResponse` because it could be useful to provide some information (e.g. contact) without forcing the user to go (again) to the info endpoint...
WDYT @juhtornr? Is there any reason to explain the fields, endpoints, parameters, etc, again in beacon.md? Because I agree with @teemukataja: it's annoying to maintain this file. I suggest: *...
This is very convenient for the .md files! (not so sure for the examples because we are currently showing real examples from a Beacon implementation, not theoretical examples) We should...
Hi guys! I don't think **sampleCount** (in BeaconDatasetAlleleResponse) is the same as AC field in VCF. Look at this example extracted from the [1000 genoms project](http://www.internationalgenome.org/data): ``` 21 9489357 rs566796439;rs544784469...
Jordi and I have been discussing this. We think that some of the field names in `BeaconAlleleResponse` should make explicit that they match the request (e.g. `variantCount` vs `variantMatchingCount` and...
I've created a PR #258 with the clarification and a [Wiki page](https://github.com/ga4gh-beacon/specification/wiki/Calculating-counters-in-BeaconDatasetAlleleResponse) explaining how to calculate these counts with an example (the same I provided here).