Sophie Dankel

Results 94 comments of Sophie Dankel

@cuishuang I'm not sure why those tests failed. Please update your branch as it is now out of date.

concurrent_slab.rs: ```rust pub fn get(&self, index: usize) -> Arc { let inner = self.inner.read().unwrap(); let value = inner.get(&index).unwrap_or_else(|| { let backtrace = std::backtrace::Backtrace::force_capture(); eprintln!("backtrace: {:#?}", backtrace); panic!("Failed to get value...

I found a workaround for this particular example, but I still think this would be useful to have. Happy to submit a PR if you agree.

This is very weird, since I see the action is only using the sha from [github.context](https://github.com/boa-dev/criterion-compare-action/blob/59f4d964c5f19d7f13d36f5c0944b18ce6652cb0/main.js#L237)

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request When the event is `pull_request`, `sha` is a commit from the merge branch: `refs/pull/PULL_REQUEST_NUMBER/merge` rather than the PR branch that users see. When the the event is `push`, it's...

I agree, this would be very nice! Even better would be an option to have the report attached to the comment.

> Deployment failed due to insufficient funds. Please be sure to have enough coins to pay for deployment transaction. Do we need to add more to the account?

@kayagokalp Can we close this since we are removing Bech32 format from the wallet?

Related https://github.com/FuelLabs/sway/issues/3176

This would be nice, but it would also require us to download the metadata file from fuelup to check if there is a new release available every time a `forc`...