Sophie Dankel

Results 94 comments of Sophie Dankel

I agree that 4 makes sense for now. In the future we could improve user-perceived responsiveness by doing something in-between options 3 and 4: we could have up to a...

This is happening for me too! Doc comment continuation is still working for me, but not comment continuation. Looking into it.

Weird, after updating VSCode, both are now working for me. I plan to replace this with a custom on_enter method implementation to remove the dependency on the client to apply...

I think we should disallow project names with dots or any special character other than `_`, similar to cargo. Numbers should be allowed but not as a first digit. Here's...

> > I think we should disallow project names with dots or any special character other than `_`, similar to cargo. Numbers should be allowed but not as a first...

> BTW, is the '-' hyphen valid in the project name? Yes, good catch! `-` should be allowed. > The function validate_name is not only used for project name but...

Fixed in https://github.com/FuelLabs/sway/pull/5975

This one is also flaky: `tx_fields::tx::can_get_inputs_count` [failed](https://github.com/FuelLabs/sway/actions/runs/7202029803/job/19619365458?pr=5390) and then [passed](https://github.com/FuelLabs/sway/actions/runs/7202029803/job/19619672460?pr=5390) on rerun

@bitzoic Does your team own these tests? Would you mind taking a look?

> Nice this will be handy. Just wondering if we should filter this job to run only if code in `sway-core` of `sway-lsp` was changed so it doesn't become noisy....