Steven Dahdah

Results 16 issues of Steven Dahdah

There is a typo in `setup.py` when specifying the `numpy` version. This makes `pip install block` fail.

If I leave these scripts running for a while, I eventually can't open any more windows. If I try and open a window from the command line I get an...

@erichson what do you think about setting up test and release automation with GitHub actions? I've done something similar with my library here: https://github.com/decarsg/pykoop/tree/main/.github/workflows It's pretty easy and I'm happy...

As @erichson proposed, we could implement ScreeNOT https://arxiv.org/pdf/2009.12297.pdf in this library as an enhancement. Adding as an issue to keep track of it. An implementation by the authors exists here:...

``` File "pykoop/koopman_pipeline.py", line 3509, in score_trajectory if not np.isfinite(score): ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all() ```

bug

To prevent breaking the API when adding new options, add `*` to enforce keyword-only arguments

enhancement

See https://packaging.python.org/en/latest/tutorials/packaging-projects/ and https://docs.pytest.org/en/7.1.x/explanation/goodpractices.html#tests-outside-application-code. Need to make sure this does not negatively impact older versions of Python (3.7+).

enhancement

Currently every subclass has to handle the episode feature itself. This is clunky.

enhancement