Sebastien Dabdoub

Results 10 comments of Sebastien Dabdoub

They are signed off with my personal email, but I guess it compares it to my git config: Expected "sdabdoub ", but got "Sebastien Dabdoub ". Ive updated them, please...

I did a blank amend + force push. It looks like it needs approval to run the tests/checks.

Looks like my amend undid the sign-off? Should be good now

ack, I wasnt sure how strict the backwards compatibility requirement was (I thought maybe on a major version, it was ok to break). I have removed the runtime_path only export,...

Ok I reworked the code a bit to make it backwards compatible. @stgraber I made use of the existing (and versioned) lxcfs_opts struct and bumped the version value to 2....

@mihalicyn let me know if I need to do anything else

Addressed the comments, thanks @mihalicyn

btw @mihalicyn it would be useful to update the README or CONTRIBUTING files with: * instructions on how to run the tests and a backwards compatibility test * the requirement...