scwhittle comments

Results 87 comments of


                                            scwhittle

[Feature Request]: Reduce FnApi error logs for processing that is cancelled for expected reasons

From discussion on beam-dev it sounds like there is agreement that adding a ErrorReason to the state request response instead of just error string would be useful for improving logging...

[Feature Request]: Reduce FnApi error logs for processing that is cancelled for expected reasons

I still plan on doing this once I get a chance

[Dataflow Streaming] Move timer tag logic to WindmillStateTagUtil

Sorry! I was waiting for tests to complete originally but I lost track of it

[Bug]: SolaceIO seems to lose messages during Dataflow scaling/rebalancing events

It was closed automatically since PR was annotated with fixing it. But reopening for verification.

Understanding effective connection attempt timeout with heartbeat and idle settings

Thanks for your response. There is still something that doesn't make sense to me. When `keepAliveWithoutCalls=true`, the KeepAliveManager is started earlier, during [onTransportStart](https://github.com/grpc/grpc-java/blob/226b1e5ecc7ddcbb819cfc893308ac46973d16d5/core/src/main/java/io/grpc/internal/KeepAliveManager.java#L152). AFAICT this may also be before TCP...

Understanding effective connection attempt timeout with heartbeat and idle settings

Thanks! So it sounds like there are some places that are perhaps missing timeouts that could lead to this stuck behavior. If keep alive without calls isn't the proper way...

Understanding effective connection attempt timeout with heartbeat and idle settings

In this instance the connection was stuck for 20 minutes following a high cpu period when it was created, not 30 seconds. This is the original observed instance without much...