scwhittle

Results 87 comments of scwhittle

This should be fixed by upgrade to 2.2.16 or higher above

Looks like this assert failed in test: https://github.com/apache/beam/blob/0bce6d7a834c521a3d3043ab9377fcd2f2e16f0a/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java#L3355 Could be flaky if doesn't wait enough to get commit or it could be an indication that the heartbeat response plumbing isn't...

That test expects 1 commit but meant to wait for some extra time to make sure there were not 2. But it should do so perhaps with larger time limit...

@Abacn Can the test be disabled or sickbayed before it is investigated? This code is not yet used in pipelines.

@m-trieu Martin can you look into fixing the test flakiness?

There are still some open comments. This is part of work to support direct path which won't be ready for the cut. So I don't think this should hold up...

The other PR is merged, woudl like to verify this passes now