squidpy icon indicating copy to clipboard operation
squidpy copied to clipboard

remove sorted ligrec plot

Open wangjiawen2013 opened this issue 2 years ago • 1 comments

Don't sorted label_rankge keys according to issues https://github.com/scverse/squidpy/issues/560#issuecomment-1152842944

wangjiawen2013 avatar Jul 03 '22 08:07 wangjiawen2013

Codecov Report

Merging #574 (caf1add) into main (2cf664f) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   72.33%   72.33%           
=======================================
  Files          37       37           
  Lines        5177     5177           
  Branches      982      982           
=======================================
  Hits         3745     3745           
  Misses       1181     1181           
  Partials      251      251           
Impacted Files Coverage Δ
squidpy/pl/_ligrec.py 90.72% <100.00%> (ø)

codecov-commenter avatar Jul 03 '22 08:07 codecov-commenter

hi @wangjiawen2013 , can you give me write access to your fork? I found the right line to fix it, you need to remove sorted from here: https://github.com/scverse/squidpy/blob/81b307d6e0696870125b1ccfc3a2fcff51b09b11/squidpy/gr/_ligrec.py#L388-L393

and not from the plotting. I could quickly wrap up the PR but I need you to grant me write access to your fork, otherwise I cannot push on this PR.

@michalk8 if you could quickly double check that removing sorted in that line doesn't mess up with rest of function downstream would be appreciated (although it shouldnt'). Thank you!

giovp avatar Aug 15 '22 09:08 giovp

hi @wangjiawen2013 , can you give me write access to your fork? I found the right line to fix it, you need to remove sorted from here: https://github.com/scverse/squidpy/blob/81b307d6e0696870125b1ccfc3a2fcff51b09b11/squidpy/gr/_ligrec.py#L388-L393

and not from the plotting. I could quickly wrap up the PR but I need you to grant me write access to your fork, otherwise I cannot push on this PR.

@michalk8 if you could quickly double check that removing sorted in that line doesn't mess up with rest of function downstream would be appreciated (although it shouldnt'). Thank you!

I don't know how to give you access right, but I have added you to my fork: https://github.com/wangjiawen2013/squidpy hope it will help !

wangjiawen2013 avatar Aug 16 '22 08:08 wangjiawen2013

@wangjiawen2013 can you re-open this PR?

giovp avatar Aug 18 '22 11:08 giovp

actually no problem, opened a new one!

giovp avatar Aug 18 '22 11:08 giovp