spatialdata icon indicating copy to clipboard operation
spatialdata copied to clipboard

Check what is passed to **kwargs in the parsers to avoid silent bugs

Open LucaMarconato opened this issue 3 years ago • 2 comments

Typos can lead to parameters being not specified inside parsers and their default value (None) can lead to nasty bugs. I would add checks that the argument passed to kwargs are actually the expected (like customization for spatial-image)

LucaMarconato avatar Dec 15 '22 17:12 LucaMarconato

Fully agreed. These types of silent errors are super frustrating to debug.

kevinyamauchi avatar Dec 15 '22 19:12 kevinyamauchi

With @melonora we discussed to drop kwargs and use named argument instead, to be fully explicit in what can be passed to the model.

LucaMarconato avatar Jul 09 '24 15:07 LucaMarconato