spatialdata icon indicating copy to clipboard operation
spatialdata copied to clipboard

Add support for remote datasets

Open berombau opened this issue 11 months ago • 4 comments

This is the PR to close https://github.com/scverse/spatialdata/issues/441.

berombau avatar Jan 24 '25 09:01 berombau

Codecov Report

:x: Patch coverage is 86.86869% with 13 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 92.01%. Comparing base (4021946) to head (d9e4eac). :warning: Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata/_io/_utils.py 76.47% 8 Missing :warning:
src/spatialdata/_io/io_zarr.py 89.18% 4 Missing :warning:
src/spatialdata/_io/io_raster.py 90.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
- Coverage   92.11%   92.01%   -0.10%     
==========================================
  Files          48       48              
  Lines        7429     7468      +39     
==========================================
+ Hits         6843     6872      +29     
- Misses        586      596      +10     
Files with missing lines Coverage Δ
src/spatialdata/_core/spatialdata.py 91.57% <100.00%> (+0.11%) :arrow_up:
src/spatialdata/_io/io_points.py 100.00% <100.00%> (ø)
src/spatialdata/_io/io_shapes.py 95.08% <100.00%> (-0.08%) :arrow_down:
src/spatialdata/_io/io_table.py 94.00% <100.00%> (-0.45%) :arrow_down:
src/spatialdata/_io/io_raster.py 96.12% <90.00%> (-0.73%) :arrow_down:
src/spatialdata/_io/io_zarr.py 87.82% <89.18%> (-0.64%) :arrow_down:
src/spatialdata/_io/_utils.py 86.52% <76.47%> (-1.93%) :arrow_down:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jan 24 '25 09:01 codecov[bot]

These are the diffs from the old PR that got closed because of the many merge conflicts. Let's use this code to shape the new implementations.

  • https://github.com/scverse/spatialdata/pull/442/files/7bb87ba5da68ab9fb4a0a7dcd06751b36290d4c1
  • https://github.com/scverse/spatialdata/pull/442/files/e6b6ae9502520f4e54f856787d3874d90a89058c..e3e0c28638ba932c62d04e6b03e4ca711d61bf27
  • https://github.com/scverse/spatialdata/pull/442/files/f1d4f27ec5e6bfc8fed36032bf50ab831d3a453f..74283b1092b8858f46e7b5980a57b6b4c03d1575

LucaMarconato avatar Jan 31 '25 11:01 LucaMarconato

I added my progress. Local read/write behavior should still work. Remote reading for raster (image, labels) elements is added. The tests succeeded locally and I expanded the remote tests for future work on reading and writing all elements.

Next steps are:

  • [x] merging with the incremental reading now in main
  • [ ] finish the public element read functions
  • [x] merge

Out-of-scope for this PR:

  • [ ] support for the remaining points, shapes and tables elements
  • [ ] support writing to remote

berombau avatar Feb 01 '25 09:02 berombau

Thanks @berombau! I will take over for this 😊 (timeline, working on 2-3 PRs and then I want to work on this next).

LucaMarconato avatar Feb 01 '25 15:02 LucaMarconato

Closing this in favor of work on the cloud branch which involves work performed during the Owkin hackathon.

melonora avatar Aug 20 '25 09:08 melonora