Support remote private storage by consistent use of substore
Closes #441, depends on (https://github.com/ome/ome-zarr-py/pull/349)
Codecov Report
Attention: Patch coverage is 71.42857% with 6 lines in your changes are missing coverage. Please review.
Project coverage is 92.52%. Comparing base (
b73f3a8) to head (7bb87ba). Report is 2 commits behind head on main.
:exclamation: Current head 7bb87ba differs from pull request most recent head c120a4d. Consider uploading reports for the commit c120a4d to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 92.53% 92.52% -0.02%
==========================================
Files 43 39 -4
Lines 6003 5270 -733
==========================================
- Hits 5555 4876 -679
+ Misses 448 394 -54
| Files | Coverage Δ | |
|---|---|---|
| src/spatialdata/_core/spatialdata.py | 94.43% <ø> (+2.21%) |
:arrow_up: |
| src/spatialdata/_io/io_raster.py | 96.29% <100.00%> (ø) |
|
| src/spatialdata/_io/io_shapes.py | 100.00% <100.00%> (+2.04%) |
:arrow_up: |
| src/spatialdata/_io/io_zarr.py | 86.08% <66.66%> (-2.29%) |
:arrow_down: |
for some reason it didn't rebase to main...
hi @berombau seems that there are a lot of conflicts, and still didnt' rebase correctly, not sure what to do but maybe worth to port over the changes to separate PR?
Yeah, I think I switched from merging to rebasing somewhere halfway 😅 I'll try to cherry-pick the changes on a new branch and do a cleaner PR.