scvi-tools icon indicating copy to clipboard operation
scvi-tools copied to clipboard

refactor(model): refactor out common minified mode methods

Open martinkim0 opened this issue 1 year ago • 2 comments

martinkim0 avatar Jul 03 '24 18:07 martinkim0

Codecov Report

Attention: Patch coverage is 92.85714% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (bcd7e67) to head (906160e). Report is 72 commits behind head on main.

Files with missing lines Patch % Lines
src/scvi/model/base/_base_model.py 87.50% 3 Missing :warning:
src/scvi/model/utils/_minification.py 91.66% 1 Missing :warning:
src/scvi/module/_vae.py 90.90% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2883      +/-   ##
==========================================
+ Coverage   84.53%   84.60%   +0.06%     
==========================================
  Files         178      178              
  Lines       15067    15052      -15     
==========================================
- Hits        12737    12734       -3     
+ Misses       2330     2318      -12     
Files with missing lines Coverage Δ
src/scvi/data/_constants.py 100.00% <100.00%> (ø)
src/scvi/model/_scanvi.py 95.91% <100.00%> (+4.69%) :arrow_up:
src/scvi/model/_scvi.py 95.83% <100.00%> (+5.42%) :arrow_up:
src/scvi/model/base/_log_likelihood.py 84.78% <100.00%> (+2.73%) :arrow_up:
src/scvi/model/base/_vaemixin.py 87.95% <ø> (ø)
src/scvi/module/base/_base_module.py 88.34% <100.00%> (+0.04%) :arrow_up:
src/scvi/train/_trainingplans.py 94.60% <100.00%> (+0.01%) :arrow_up:
src/scvi/utils/_decorators.py 100.00% <100.00%> (ø)
src/scvi/model/utils/_minification.py 93.33% <91.66%> (+1.02%) :arrow_up:
src/scvi/module/_vae.py 94.92% <90.90%> (+0.43%) :arrow_up:
... and 1 more

codecov[bot] avatar Jul 03 '24 18:07 codecov[bot]

@martinkim0 Was this one ready to merge or are things missing?

canergen avatar Jul 26 '24 19:07 canergen