scvi-tools icon indicating copy to clipboard operation
scvi-tools copied to clipboard

Can hub paper

Open canergen opened this issue 1 year ago • 2 comments

Adds minified mode to CondSCVI. Simplifies minification for new models. Adds add_latent_posterior mode which keeps count data. Fixes glitches in DE function.

  • [X] Tests added and passed if fixing a bug or adding a new feature
  • [X] All code checks passed
  • [X] Added type annotations to new arguments/methods/functions
  • [ ] Added an entry in the latest docs/release_notes/index.md file if fixing a bug or adding a new feature

canergen avatar Jan 05 '24 20:01 canergen

Codecov Report

Attention: Patch coverage is 92.94118% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.94%. Comparing base (9b5f553) to head (0178d45). Report is 150 commits behind head on main.

Files Patch % Lines
scvi/model/base/_base_model.py 88.00% 3 Missing :warning:
scvi/module/_vaec.py 92.30% 2 Missing :warning:
scvi/model/_scanvi.py 75.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2379      +/-   ##
==========================================
- Coverage   89.42%   88.94%   -0.48%     
==========================================
  Files         153      153              
  Lines       12566    12566              
==========================================
- Hits        11237    11177      -60     
- Misses       1329     1389      +60     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 05 '24 20:01 codecov[bot]

If possible, could you separate this out into 4 PRs:

  • Minified mode for CondSCVI
  • Simplification of minification for new models
  • add_latent_posterior mode
  • Fixes in differential expression

Thanks

martinkim0 avatar Jan 10 '24 23:01 martinkim0