scanpy
scanpy copied to clipboard
missing var_names in BasePlot
- [x] Closes #3387
- [ ] Tests included or not required because:
- [ ] Release notes not necessary because:
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 75.45%. Comparing base (cce4bd6) to head (73f6c0b).
:warning: Report is 133 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #3460 +/- ##
=======================================
Coverage 75.44% 75.45%
=======================================
Files 113 113
Lines 13250 13254 +4
=======================================
+ Hits 9997 10001 +4
Misses 3253 3253
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/scanpy/plotting/_baseplot_class.py | 91.64% <100.00%> (+0.09%) |
:arrow_up: |
Hi! var_names can’t just contain values from .var.index, but also other sources, handled by
sc.get.obs_df(adata, keys=keys, layer=layer, use_raw=use_raw, gene_symbols=gene_symbols)
One approach could be to add a warn_only: bool = False parameter to .sc.get.obs_df which could then be specified in the plotting function.