Volcano

[eburke21]

[codecov[bot]]

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cab9f78). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2241   +/-   ##
=========================================
  Coverage          ?   71.74%           
=========================================
  Files             ?       99           
  Lines             ?    11560           
  Branches          ?        0           
=========================================
  Hits              ?     8294           
  Misses            ?     3266           
  Partials          ?        0           

[Zethson]

Hi,

thank you for your PR.

Could you please:

1. Update the body of your PR to introduce and explain what, why and if required how you are doing things.
2. Why do you think that the volcano plot should go into external? It could go into our core plotting functions, no?
3. Please try to hardcode as few things as possible. Also, please use the scanpy settings object for plots (e.g. the figure size)

[Zethson]

Closing as stale. Please feel free to reopen if you're willing to take this PR further.