Cristi Burcă comments

Results 94 comments of


                                            Cristi Burcă

Added logic to insert whitespace after NOT operators

Can you post a few "before and after" examples of this new behavior?

Added logic to insert whitespace after NOT operators

Actually, I think this would be a good time to introduce some phpunit tests that cover all the branches touched by the pull request: T_IF, T_WHILE etc.

Added logic to insert whitespace after NOT operators

I know that, compared to implementing a new feature, writing tests seems like a chore, but it's necessary, particularly for such a script, with many many branches. If you're not...

Incorrect indentation for multiple open parentheses on the same line

When passing the first code block through wp-phptidy, it should remain unchanged.

newline T_OBJECT_OPERATOR indent

We should add some automated tests before making this change. I'm thinking a series of sample PHP code that needs to remain unchanged when passed through phptidy.

newline T_OBJECT_OPERATOR indent

> i think we could copy how the laravel blade template "engine" tests are done. The problem with that approach is that it's messy to have big chunks of PHP...

Use editable_option() on a key within an options array

That's a good idea. editable_option() could accept a 'subkey' parameter: ``` php ```

Use editable_option() on a key within an options array

It prefixes the option name with `editable_option_` for safety. You can disable the prefixing by passing `theme_option => false`: `editable_option( array( 'key' => 'my_option', 'theme_option' => false ) );`

Use editable_option() on a key within an options array

This is a bigger problem that needs to be fixed: #57

Use editable_option() on a key within an options array

I guess you can put it like that.