Cristi Burcă

Results 94 comments of Cristi Burcă

> AFAIK it was down to missing files / unable to file certain files. You need to install the Composer dependencies. See the updated [CONTRIBUTING.md](https://github.com/scribu/wp-posts-to-posts/blob/master/CONTRIBUTING.md).

> As WP_Query and WP_User_Query can't be used is it possible to convert these function to use $wpdb? If BuddyPress doesn't have an equivalent class, like BP_Group_Query, then yeah, using...

> If they can be modified how can the arguments be passed along? If there is no BP_Group_Query class to hook into, you will still be able to use `p2p_type(...

Cool, but if you look at the [changed files](https://github.com/scribu/wp-posts-to-posts/pull/454/files) you'll see that there are 4 that need to be deleted from this PR: - bin/install-wp-tests - core/item-bpgroup.php - core/query-bpgroup.php -...

Please describe your solution in a few words (it's not very clear by looking at the diff).

Ok, the diff looks decent now. I would like to see a unit test for this in `tests/test-core.php`. See CONTRIBUTING.md for instructions.

Erm... the instructions for running the unit tests are incomplete. I'll update them soon. Even so, they probably don't work on Windows, unless you have Cygwin. However, you can try...

There: https://github.com/scribu/wp-posts-to-posts/blob/master/CONTRIBUTING.md#unit-tests You'll need to switch to the latest master branch (3e5542548f51b757e117612f94d1b75f43d1b573) to see the `./bin/install-wp-tests` script.

The "The Travis CI build passed" message just means that the current patch passes all existing unit tests. If you want to help, you can start using [Oreolek's fork](https://github.com/Oreolek/wp-posts-to-posts) and...

It's safe in the sense that it won't delete your connections or anything like that. :P I have no idea if it fetches the correct posts, what happens if you...