Sylvain Coulombel

icon indicating a website link coulombel.net

icon location Antibes icon location DevOps @ Amadeus

Results 5 comments of Sylvain Coulombel

Fix inconsistent behaviour when a charset is defined in Content-Type header value with an invalid and valid json #1202

I tested it locally here: https://github.com/scoulomb/zalando_connexion_sample (+buildLocalLib branch) I did not see specific unit test to update, what would you advise?

Fix inconsistent behaviour when a charset is defined in Content-Type header value with an invalid and valid json #1202

Fix loss of coverage here: https://github.com/zalando/connexion/blob/c99dda68f4cad9e36815267eb68898220499ee5c/connexion/decorators/validation.py#L142

Fix inconsistent behaviour when a charset is defined in Content-Type header value with an invalid and valid json #1202

I added unit test in test_json_validation.py However loss of coverage was due to the fact that in the former version of the code we were doing tuple unpacking after the...

Fix inconsistent behaviour when a charset is defined in Content-Type header value with an invalid and valid json #1202

Hello @hjacobs , I fixed https://github.com/zalando/connexion/issues/1202 in this PR. Would you mind please have a look? Thanks a lot.

Fix inconsistent behaviour when a charset is defined in Content-Type header value with an invalid and valid json #1202

@hjacobs do you think this PR is mergeable, or should I rework on it?