Scott Lewis

Results 37 comments of Scott Lewis

One more thing: I *did* not change the code in Protocol.getReturnValue() that combines the python output from traceback.format_exc with a String message to create and throw a Py4JException. What I...

Hi Barthelemy, >If I understand correctly, we would pass the exception string received from the Python side and wrap it >into a PythonThrowable. Instead of raising a Py4JException, we would...

Hi Barthelemy. Added support for Python chained exceptions. to PythonThrowable, and added test case. I am going to add another chained exception test case but it's going to take a...

Hi Barthelemy. I will produce additional tests and examples as you describe, but it's going to take a couple of days due to other commitments. Please lmk if that holds...

BTW...I did try to put an example in the javadocs for PythonThrowable and one of the ci checks (findbugs?) complained about it, so I removed it from javadocs. We can...

Hi Barthelemy. I've just committed some more improvements...i.e. added test code for chained exceptions, made the PythonThrowable string parsing more robust (with new/additional tests) and added toString() implementation that allows...

Hi Barthelemy, >There were two concerns: (1) complexity and general "brittleness" of such implementation WRT brittleness: Although I don't think PythonThrowable is likely to be brittle, I would suggest that...

Are there plans to merge this? If so, as mentioned in earlier comment, I would suggest the following...so as to prevent a possible PythonThrowable parsing failure (e.g. due to changes...

Hi bartdag. It might be a good idea to consider using jnr unixsocket: https://github.com/jnr/jnr-unixsocket. It's a native impl of unix sockets in java. It's being used at Eclipse projects and...

I've been playing around with the code and I have some thoughts I want to propose and discuss. First, we could add a ClassLoadingStrategy param to the GatewayServer constructor...e.g. ```...