scottp-dpaw
scottp-dpaw
From our experiences in production, SetWeak barely ever gets called (even with the context deleted and the v8 garbage collector pumped), and the v8 docs state SetWeak shouldn't be used...
The use-after-free I can't seem to replicate; my understanding is the refcount for a Python object is increased when it is added to each context, so removing one context altogether...
Everything should be sorted now, is there anything else required for review? It would be fantastic if this could be rolled into a point release, we've found with this fix...
See https://github.com/tbodt/v8py/pull/39
Done, sorry about that!
Fixed. I added a guard for `String.fromCodePoint` as well, given it's the same age as `String.codePointAt`
Just wanted to say thank you for this patchset, am also experiencing this issue in trying to suppress `django-manager-missing`.
Also there's an additional error code validator in the config parser, I would suggest removing it so that pyproject.toml works - https://github.com/scottp-dpaw/mypy/commit/4fe7aeb12189f4afcc3167ddf8d8f559452a6d08
I rebased the changes on the latest master in https://github.com/scottp-dpaw/mypy/tree/v1.8.0_fixes
No worries. In lieu of making constants for every bitmask, I've added clearer comments describing the sequence of bits that we're trying to find for each codepoint. Hopefully that should...