mattermost-plugin-remind icon indicating copy to clipboard operation
mattermost-plugin-remind copied to clipboard

Issue 73

Open scottleedavis opened this issue 5 years ago • 11 comments

Issue #73

Adds post dropdown menu + submenu for scheduling

scottleedavis avatar Jul 30 '19 19:07 scottleedavis

Codecov Report

Merging #137 into master will increase coverage by 2.94%. The diff coverage is 78.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   66.45%   69.39%   +2.94%     
==========================================
  Files          12       12              
  Lines        3139     3333     +194     
==========================================
+ Hits         2086     2313     +227     
+ Misses        816      780      -36     
- Partials      237      240       +3
Impacted Files Coverage Δ
server/activate.go 65.3% <ø> (+1.3%) :arrow_up:
server/plugin.go 100% <ø> (ø) :arrow_up:
server/http.go 73.78% <70%> (-0.99%) :arrow_down:
server/reminder.go 73.01% <89.88%> (+3.91%) :arrow_up:
server/occurrence.go 61.9% <0%> (+0.12%) :arrow_up:
server/list.go 67.57% <0%> (+16.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 55d786e...b634bc7. Read the comment docs.

codecov[bot] avatar Jul 30 '19 19:07 codecov[bot]

Screen Shot 2019-07-30 at 12 11 52 PM

scottleedavis avatar Jul 30 '19 19:07 scottleedavis

requires release v5.16.0

scottleedavis avatar Aug 08 '19 19:08 scottleedavis

Hey @scottleedavis! Few days ago v5.18 was released... any chance you can continue with this pull request?

andrey-yantsen avatar Dec 27 '19 11:12 andrey-yantsen

Hey @scottleedavis! Any chance you can continue with this pull request?

frcho avatar Apr 27 '20 14:04 frcho

@hanzei @kaakaa would either of you be able to pick up and improve what I started please?

scottleedavis avatar Apr 27 '20 15:04 scottleedavis

@frcho I am not able to contribute currently. i did contribute the submenu functionality needed in MM-webapp https://github.com/mattermost/mattermost-webapp/pull/3357

scottleedavis avatar May 02 '20 17:05 scottleedavis

I will gift a $50 amazon gift card to the first person who completes this PR. And some Mattermost stickers. IMG_0645 copy

scottleedavis avatar May 10 '20 16:05 scottleedavis

@scottleedavis awesome job! Do you have some news when this might be merged? That would be a huge step for people migrating onto Mattermost.

zifeo avatar Jun 22 '20 19:06 zifeo

Hey @scottleedavis I see you're asking for help on this issue, what is required to get it across the line? Some updates / tests passing or.... ?

I'd love to help, as I love this feature in slack

benbernard avatar Jul 10 '20 20:07 benbernard

Hi @benbernard I took a look into this PR, and I think this feature could be made to work with a few more tweaks (e.g.: my work). However, while I was working on this, I found a CSS issue in the Mattermost codebase, so I think we'll have to fix it before this. (It's difficult for me due to my little knowledge about css...) https://github.com/mattermost/mattermost-plugin-demo/issues/101

kaakaa avatar Jul 11 '20 14:07 kaakaa