Scott C Wilson
Scott C Wilson
a) Can this be reproduced using the current unmodified contents of the Github master branch? b) If so, how do you reproduce it? Also if so, please do PR. Thanks.
WOW! Great stuff. When merged I will update https://docs.zen-cart.com/release/whatsnext/ to move this feature to 2.1.
Couldn't we fix that with a SQL UPDATE in the 2.1 upgrade script? Similar to the ALTER TABLE statements we did in case dimensions were already in the products table?
The concern that "non-encapsulated versions of the plugin ... won't find the pre-existing configuration settings."
If you do this, please make it switchable; some storeowners will not want this behavior.
All or none. Just like wholesale pricing - it's on or off.
1.5.8 also created download-only orders with no shipping address, but this error didn't seem to occur.
Sorry should have been more precise. This is PayPal Express.
I have no preference for where the fix is done. Doing it in the paypalwpp module would be fine. I'm mostly curious to see if others have had this issue.
Looked at some older PayPal orders on my cart (1.5.7 timeframe) and found they also had no shipping address. Changing title to more accurately reflect the issue.