Scott C Wilson

Results 248 comments of Scott C Wilson

See #5505 - you shouldn't use the extra_* folders in an encapsulated plugin.

The same problem exists with classic plugins - you'd have to ifndef any function that might be defined by another plugin.

> Is javascript form-checking now considered unnecessary ... No - it saves a form submit to do pre-checking and flag things that won't work.

> I don't see the logic behind an admin switch for displaying the drop down or not, when zones are already defined for that country. I would agree with you...

New class `includes/classes/productPulldown.php` should suffice. If additional notifiers are required, please PR.

This function was deprecated in 1.5.8 with the comment "Use markup instead." As an example, in 1.5.7, coupon_admin.php did this: ``` ``` This has been changed in 1.5.8 to: ```...

You can put out a plugin that's not "drop in" - like I said, I don't want to add things that are only desirable to a small number of people.

@drbyte Would you please resolve this when you have a moment? Thanks.

Can this be closed? I thought you could use the SQL Installer Classes in the updated version if changes were required - no? https://docs.zen-cart.com/dev/plugins/encapsulated_plugins/sql_installation/#sql-installer-classes