Carol A. Scott

Results 10 comments of Carol A. Scott

Hi @patrick-fs thanks for the quick response! Yes, we import [prop-types](https://www.npmjs.com/package/prop-types) into each of our component files and then explicitly set PropTypes declarations - here's a sample: ``` MyComponent.propTypes =...

@patrick-fs Thanks so much for taking a look. I have more question related to our use of this library. In our app, we frequently render many versions of the same...

@patrick-fs Thanks so much, will dig in to this. To confirm, setting our own data attributes would be separate from our use of this plugin, is that correct?

Ok, thanks for the info @patrick-fs!

Hey @TrevorFSmith, thanks so much for looking into this, appreciate the help from the FullStory team. I will take a look by end of the work day Friday (Pacific).

Hi @j6design, it looks like the placeholder text is being used as a label (not good for a11y). Can you brainstorm a better solution with me? Here is the current...

Hey @jszwedko see this article on [using placeholders as labels](https://www.nngroup.com/articles/form-design-placeholders/). Any chance we can add a visible label to the address search form? Otherwise, I can submit a pull request...

@jeanwalshie Thanks! I'm getting my adopt-a-drain feet wet (pun intended) and would like to start with a11y issues. Planning to come to the coding meetup 9/13 to meet some collaborators...

@jszwedko - great. Something came up and I won't be there tonight but I will be there 9/20. I'll submit a pull request for this as soon as I can.

Oops yes I meant I won't be there *today* (Wednesday) but will be there next week!