accessible_modal_window
accessible_modal_window copied to clipboard
scottaohara
Accessible modal dialogs
Hey man, I noticed a missing comma in the CSS file. I wanted to add an issue for that but found out you already fixed that in master. However it's...
Here's a minimal example showing the problem: https://jsfiddle.net/s9v6r2nt/1/ Clicking in the center of the button doesn't work, only clicking at the very edges (outside the span) can you open the...
Currently the library gives errors when removing focusable elements in the dialog. The tab wrapping stops working if the last focusable element in the dialog is removed. This [can be...
Hey! Thanks for this amazing package 😊 Is it possible to listen for open/close events on a dialog? I have embedded a video in the dialog but it keeps playing...
I'm trying to initialize modals for items added via an infinite scroll script. It isn't working, however, because `var modal` isn't accessible globally. The scoped `modal` variable is throughout the...
When trying to use https://github.com/WICG/inert as the inert polyfill, I found that setting focus after closing the modal was not working because inert was not really removed yet when focus...
I noticed that the minified code did not get updated when I did the improvement to support multiple trigger buttons. As I could not find documentation on how it's generated,...
RawGit has been placed in sunset mode, with [a disclosure](https://rawgit.com/) that support may end in October 2019. jsDelivr offers a RawGit migration, so here's Google's inert polyfill re-hosted: https://cdn.jsdelivr.net/gh/GoogleChrome/[email protected]/inert-polyfill.min.js
A modal dialog could very well be triggered from within a `menu`, so the current setup of enhancing non-`button` dialog triggers into `role=button` is a bit overzealous.
See #6 for more information. I know this isn't the best solution, but I'm not a great JS developer. Another alternative would be to add something like this: ``` /**...