accessible_modal_window
accessible_modal_window copied to clipboard
Improve generating the minified code
I noticed that the minified code did not get updated when I did the improvement to support multiple trigger buttons.
As I could not find documentation on how it's generated, I created this pull request to use uglify-js for minifying via npm script. I also added a bit of documentation so that others would not have to wonder as much how to contribute.
- Add uglify-js to minify javascript
- Add
npm run uglify
script to generate the minified (and unminified version for debugging) version - Add contribution documentation
- Bump up version number to 3.4.1
Maybe after this a new release could be created?
hey again.
Actually, I've been meaning to just delete the minified JS so that people could just use whatever minification / build process they want to.
I think removing the minified version might be a bad idea.
If you check the google inert code, it too has minified code for ready use.
People might want to just get the minified version directly without always building a minifying workflow to their system. This way people do not have to build their own tooling for simple use cases.
This pull request is about having a simple tooling in the project for minifying the code automatically helps with contributions.
i understand the intent of the PR. It just conflicts with what I was planning on doing here.
I'll think on it.
However, i definitely don't see value in copying over the unminified index.js file into the assets folder.
Yep, maybe copying the unminified can be removed. Usually when you concatenate several scripts to one, it's a good idea to create so I did it out of habit. But here the need for that is not as clear.