scott-thrillist
scott-thrillist
> You have to manually Enable it in the dropdown menu now though, which is annoying. Thanks @okiyama I was so used to just starting the app when OSX restarted...
I love how I randomly stumbled on this issue and got an 🤯 when I found out dimensions attributes are now supported in Chrome 90. Just waiting on Safari...
@squgeim thanks for diagnosing the issue. @daraclare can you take a look at this bug. I tried updating to the latest version and am getting this error as well.
@evgenizhuk @jaanauati what are you thoughts on keeping this component brand agnostic of add-ons? We use Amazon TAM + react-dfp as well but simply utilize the built-in AdSlot props to...
Ps- here's the original PR that allowed react-dfp to work with Amazon TAM https://github.com/jaanauati/react-dfp/pull/158
@yahenizhuk Here's a snippet I created for someone else. I may clean this up and make an example within this project when some time opens up. https://gist.github.com/scott-thrillist/bf7d429f6c78a417fe4717a2e1791dc1 A potential downside...
@yahenizhuk Gotcha and thank you. Can I ask what are the requirements that this doesn't meet? Always interested in understanding how other organizations implement ad bidding with DFP.
Thanks for sharing. We implement conditional ad bidding as well, and simply refresh the ad sans-TAM if it doesn't meet the condition. But I understand everyone has different requirements. Happy...
I'm seeing this issue still marked as open but notice the intersection observer js file in my lazysizes npm package. Is it being used in this plugin or not? Edit-...
Thanks for this patch Steve, but this doesn't work out of the box. Need to do this on the return: `return $this->_reservePlace($typeJS && $this->_needsCdata($js)` Otherwise it reinserts the CDATA for...