Scott Huberty

Results 116 comments of Scott Huberty

> looks like your renaming removed all the git history of the files (deleting file -> creating new file with all new code without history) > > if you use...

> We will squash+merge when merging anyway, which will destroy any history of `mv` or whatever. In the end all lines will look like they were committed by a single...

No worries @schekroud there can be a learning curve for PR's. Have you read the [contributing guide](https://mne.tools/dev/development/contributing.html)? I still use it from time to time to remind myself. One comment...

I just took a closer look at this PR. It looks like most of the failing tests are unrelated, and I think all of them should have been fixed by...

Hi @schekroud do you still have time to work on this? I think you just need [to merge in the updates to mne ](https://mne.tools/dev/development/contributing.html) since your last commit, and add...

> ... bonus points if this somehow takes care of https://github.com/mne-tools/mne-python/pull/11674 / https://github.com/mne-tools/mne-python/issues/11626 / https://github.com/mne-tools/mne-python/pull/11627 As suggested [here](https://github.com/mne-tools/mne-python/pull/11674#issuecomment-1631560083) I can quickly check if simply allowing the initial one-shot event fixes...

> @scott-huberty we're planning to release in 3ish weeks and it would be great to get this in, let me know if you want help I've just moved to a...

Thanks for the report! I think we need to account for `raw.first_time` in the `interpolate_blinks` function, which will be non-negative after you call `raw.crop`: https://github.com/mne-tools/mne-python/blob/65d826d199c3bbed0ee7035dda0f4560282b43ff/mne/preprocessing/eyetracking/_pupillometry.py#L75-L100 starting at line 89 above,...

> neat! Thanks for the quick fix - would it be ok to change my `pupillometry.py` to include that fix until it's released? @schekroud would you be up to submit...