Scott Huberty

Results 115 comments of Scott Huberty

Hey @dominikwelke , I think the parser is looking good! ![image](https://user-images.githubusercontent.com/52462026/212774554-64f5b6ea-ce0e-4bfc-b93a-6d98ca7d582f.png) I haven't really touched your code on setting channel and FIFF types, but I see you did some refactoring...

One comment on the DIN (digital input port) data in Eyelink files.. Eyelink tracks the pin downs/ups of a DIN port for every sample of the file, so if I'm...

> One comment on the DIN (digital input port) data in Eyelink files.. Eyelink tracks the pin downs/ups of a DIN port for every sample of the file, so if...

> > treating DINS as stim channel makes sense, imo. > > Agreed > > > for the other channel types: we can define new coil types, if needed. [...]...

> Concerning the choice of branch/PR: moving the preprocessing code from my current branch into a separate branch+pr would be a matter of seconds, as it happens in entriely different...

> maybe add one to the latter that just shows you can read some data, epoch it, and make an average of some sort (e.g., of pupil size)? Even if...

Thanks again @dominikwelke for merging in your updates - I can tell that you put a lot of work into this! As I understand it, to create the `info` object...

> yup, i accepted the invitation but my pushs were still rejected. hope i can solve this for subsequent commits [...] i will change this today, its not much work...

> some other reader functions (e.g. the eeg ones) have input arguments to specify channels with certain types (misc/eog...) > we could include smth like this here as well, though...

> ... probably not terribly useful, but in case you want some inspirition here is a tutorial I made ages ago for the defunct `pyeparse` > > https://github.com/pyeparse/pyeparse/blob/master/examples/plot_from_raw_to_epochs.py Also @dominikwelke...