Stefano Cordio

Results 593 comments of Stefano Cordio

I'm reopening this to signal that an upgrade of `google-java-format` to at least [1.27.0](https://github.com/google/google-java-format/releases/tag/v1.27.0) is required when running on Java 25: ```xml 1.27.0 ```

Hi Team, would you consider not shipping JUnit dependencies transitively? Having them transitively can easily cause side effects like https://github.com/junit-team/junit5/issues/4335#issuecomment-2676800627. JUnit Pioneer is clearly usable only in a JUnit environment,...

> But that's... not really true? I think we need to take another look at how Pioneer is 'related' to JUnit proper. I think the main problem is when Pioneer...

> A transitive dependency is a (2nd or higher level) dependency of a dependency of a project. I meant it from the eyes of the Pioneer user, where Pioneer is...

> Then we reduce the chance of incompatible changes. If you check my example above, I'm saying the opposite: as soon as the user upgrades JUnit to a version newer...

Hi @danigiri, thanks a lot for the PR and sorry for the slow feedback! We're a bit behind with reviews, but we'll eventually get back to this change. I'm going...

> I will look at the javadoc check and see what is is about Between the warnings that you don't have to focus on, I can see this: ``` [ERROR]...

If I understand correctly, AssertJ breaks Spock interoperability as soon as the `then` block has string assertions like in the second example but it works correctly in the first example,...

I also have the feeling preventing specific method names in AssertJ shouldn't be the way to go but I'm happy to elaborate on it better. @nweiser94 would you mind raising...

> I actually think that this is not just a Spock specific issue, but a more general conflict with the Groovy language as assertj now hides Groovy built-ins. I'm reading...