Stefano Cordio

Results 595 comments of Stefano Cordio

I don't think we should take away the option of providing `null` values. This means that supporting such a feature would require an additional overload for each assertion that today...

I'm not sure I understand how this can work without an additional overload. Are you willing to start a PR so that we can discuss it in front of an...

We might consider something like #2724, if possible at all.

+1 on supporting values only via `usingValueComparator`

Once we address #3818, there won't be the need to expose `usingComparatorForType` in Map assertions so the API surface will be cleaner.

`usingEqualsForValues` looks good 👍 in line with [`usingEquals`](https://www.javadoc.io/doc/org.assertj/assertj-core/latest/org.assertj.core/org/assertj/core/api/Assert.html#usingEquals(java.util.function.BiPredicate)) and similar to [`withEqualsForType`](https://www.javadoc.io/doc/org.assertj/assertj-core/latest/org.assertj.core/org/assertj/core/api/RecursiveComparisonAssert.html#withEqualsForType(java.util.function.BiPredicate,java.lang.Class))

junit-build? Biased by [AssertJ](https://github.com/assertj/assertj/blob/cc5dc689ab259401fef852b35f767093fca4fa28/pom.xml#L6) and [Spring Boot](https://github.com/spring-projects/spring-boot/blob/139436ea23cbefbe315aaf17de9d4c50483eb8b4/settings.gradle#L24) 🙃 although it's "hidden" and not the actual repo name

> create your custom check logic with the [report](https://www.jacoco.org/jacoco/trunk/doc/ant.html#report) Ant task (can be embedded in a Maven build) EqualsVerifier implemented this option via the [`equalsverifier-aggregator`](https://github.com/jqno/equalsverifier/tree/b627a44a1c640e4c17981229bd5e23e0b589df02/equalsverifier-aggregator) module.

An alternative might be to adopt the Kover Maven Plugin which seems to support [multi-module projects](https://kotlin.github.io/kotlinx-kover/maven-plugin/#multi-module-projects). The Kover Maven Plugin [wraps the IntelliJ coverage agent](https://github.com/JetBrains/intellij-coverage?tab=readme-ov-file#how-to-use-intellijcoverage-agent-in-your-project), which is the suggested coverage...