Ville Skyttä
Ville Skyttä
This is good stuff, however I'm somewhat unsure of it because of two issues. I'm not saying I'm rejecting it, just explaining why it might take some time to apply...
Don't know what to do requests like this. Pretty much the same justification could be given for every single command we invoke, they could be defined as aliases or functions...
Also, I think this deserves some more test cases, see lib/completions/man.exp
An extensive change like this would be much better off with a slew of new test cases for the test suite. Running it is somehow broken in Travis at the...
Wrt getting docs to work, see doc/testing.txt. More info for your failing runCompletion should be in test/log/completion.log
Oh, and the commit message needs work, something like "VBoxManage: New completion" would be appropriate.
Just open a PR. Be sure to look at CONTRIBUTING.md, and include also new cases for the test suite for your changes if at all applicable (meaning if they're testable...
This is the first time I've heard of `CLICOLOR_FORCE` and I don't have a system to test it with, but from what I understand I think enabling it globally is...
That's a fair question. I think we should not mute everything, #508 has a candidate fix. Thoughts?
Ooh, awesome work, thanks! I'm leaning towards letting those scripts break "loudly", I think this is a good thing too. If those scripts were defining their completions conditionally based on...