Ville Skyttä
Ville Skyttä
My experience has been that reviewers here generally do a great job. This doesn't mean that something like what's suggested here would not be valuable, on the contrary. What I'd...
Hmm, I've always thought that the focus/scope of source code would include comments, docstrings, error message strings etc. Granted, I guess that'd mean a general purpose checker with some specific...
#726 would likely fit the bill, depending on the implementation, and be a cleaner solution overall. But there are a number of concerns already raised over there; this one's much...
Hm, I'm not sure, in #169 ResponseErrorLoginRequiredException and ResponseErrorNotSupportedException are the suppressed exceptions, whereas here ResponseErrorWrongSessionToken is raised. Then again I might be missing something. Or then again ResponseErrorWrongSessionToken could...
Here are some samples: https://github.com/search?q=extension%3Apo+msgid Right, *.pot would be a candidate for exclusion too, but I suppose *.mo is already excluded due to binaryness. Also, *.ts are usually Qt's similar...
Just started using setup-nox myself, bumped into this one, and had a go at fixing it: #437
JFYI/aside rg 3rd party loader in https://github.com/scop/bash-completion/pull/1148
Can do later. In the meantime, can you confirm that the intent is not to warn about the cases above, i.e. when a `http.Request` is passed, and its `.Context()` is...
I considered changing the signatures already, but doing so would be possibly misleading and just to appease contextcheck, so I decided against it. Would it not be ok to change...
For my use case the addition of `//nolint:contextcheck` is unnecessary here, because the exactly same can be done already through golangci-lint. In absence of changing the default/builtin behavior, I would...