Ville Skyttä

Results 373 comments of Ville Skyttä

Rebased. MarkdownLint CI failure seems unrelated, this doesn't touch any markdown files. I don't have rights to modify the PR labels, so it seems I can't do anything about the...

"At least some" can be said about Huawei devices as well, I wouldn't read too much into it. Supported brands in the manifest I can see being useful in addition...

> Well, we should hold it back, as stuffing multiple brands in the integration name isn't really nice either. This comment seems to confirm that the addition of a logo...

Removed changes to user visible strings. Comments are not affected by the other mechanisms, so I thought we might as well apply changes to them as they're ready here.

> Maybe `--showcmd=jobfile` can also be supported? I'm unable to find a version that would allow an argument to `--showcmd`; the one on Ubuntu 14, Debian 10, and current Fedora...

Cool, fixes to the issues you found sent upstream: https://github.com/axboe/fio/pull/1460, https://github.com/axboe/fio/pull/1462

I don't have good ideas offhand how to fix this. Getting rid of the duplicate would be fairly easy, but it'd get rid of the command, leaving only the dir...

I took the liberty to add some more test coverage in 388a8ce6604d413dd8e97c1e1de60dfe447bcff8 and b22af054ff5da64370eaf0c17a34eb1d650993ce, I think we're good to go with this now; I hope I didn't break anything. Thanks!

I believe (but haven't checked thoroughly) that 19840401612f23582e819ef277260299151334c6 here may have caused https://github.com/scop/bash-completion/issues/836

Both 4f6e424 and 5435b7c look good to me, thanks!