bash-completion
bash-completion copied to clipboard
feat(__load_completion): search more paths based on the command location
I'm sorry. I just made a mistake. I intended to open a PR in my local repository for testing purpose.
Just wondering if this was reopened on purpose, at least there are some conflicts to be resolved...
Ah, sorry for confusing you. I reopened this on purpose, rebased it, and planned to add a description, but I became busy and left it in the current status [Note: GitHub seems to disallow/unrecognize the rebasing of the closed PRs, so I needed to reopen the issue before I push the rebased commits]. I had actually already completed the rebasing in my local repository but intended to push it after I add descriptions of the PR. However, I forgot the details of the PRs so need to take the time to look at it again.
Now I have pushed the rebased commits, but it's not ready for review because I haven't added descriptions of the PR.
I have converted this to Draft PR. I'll later add the description and make it again a (normal) PR.
The original reason that I decided to reopen the PR at this timing is that I wanted to use _comp_split
contained in this branch for another failglob fix 76402f781fdbb50c70df28c69703653dbcceeacb.
I think this is the time to revisit this PR. I actually forgot about the details of the backgrounds, but now I think the code/doc change tells everything essential about the change.
I picked the changes of #823 (in commit ae26eafe86f8c4404b0ad903c9ff8bcfa55d1c85).
rebased & squashed
I took the liberty to add some more test coverage in 388a8ce6604d413dd8e97c1e1de60dfe447bcff8 and b22af054ff5da64370eaf0c17a34eb1d650993ce, I think we're good to go with this now; I hope I didn't break anything.
Thanks!
Thank you for reviewing and merging the PR!
I believe (but haven't checked thoroughly) that 19840401612f23582e819ef277260299151334c6 here may have caused https://github.com/scop/bash-completion/issues/836