S. Co1

Instead of doing this, maybe use 3.0 to drop support for type comments entirely. How often are they used nowadays in a non-Py2 codebase? Follow-up edit: There is also discussion...

Looks cool to me

The referenced cleanup would be good to do but it's not going to fix this specific issue. I think the solution is ultimately an upstream one, but regardless of what...

This should now be resolved upstream via https://github.com/PyCQA/flake8/pull/1609 🎉 ``` $ flake8 --extend-ignore=E501 --extend-select=B950 --max-line-length=9 bug.py bug.py:1:12: B950 line too long (11 > 9 characters) $ flake8 --extend-ignore=E501 --select=B950 --max-line-length=9...

Flake8 5.0 has landed with these changes: https://flake8.pycqa.org/en/latest/release-notes/5.0.0.html

The README could probably be updated to `flake8 >=5.0` for `extend-select`, perhaps with a second configuration example that works as expected pre-5.0 for folks who aren't able to update for...

This has also popped up in #221

Bugbear's built-in filtering for opinionated warnings isn't aware of `extend-select`, since the code predates its addition to flake8: https://github.com/PyCQA/flake8-bugbear/blob/1c47a162d4b2c41ada9164a12b536d6f49833d7e/bugbear.py#L152-L154 There is some talk in https://github.com/PyCQA/flake8-bugbear/pull/218#issuecomment-1012533478 about removing the `should_warn` method...

Can you reproduce with flake8@main? This may be https://github.com/PyCQA/flake8/issues/284 (e.g. https://gist.github.com/sco1/7c544878bde10163258435f9e8ae5b11), which is fixed but not part of a release yet.

Before https://github.com/PyCQA/flake8/pull/1576 it wasn't possible for `select` to be empty but the PR appears to have gotten rid of the default value. Flake8 has a bit of a complicated mechanism...