Stephen Levine

Results 81 comments of Stephen Levine

> if we indeed want to inline what clusterruntemplate provides, what do we do about runnnable.spec.selector? I believe that requires some form of interpolation from Runnable itself Maybe `selector` actually...

I wonder if we could combine this with more intelligent (perhaps field-based?) matching between Workloads and SupplyChains to reduce or eliminate the usage of YTT.

> Since matchFields is generic and able to match any field within the resource, I'd rather not overload that syntax by creating shortcuts for params. @scothis We already have this...

The buildpacks template using the [CF Java buildpack](https://github.com/cloudfoundry/java-buildpack). This takes a JAR or WAR as input. You can either extract the contents of the JAR/WAR to `/workspace`, or you can...

I'm unsure if that's on the roadmap for the CF Java buildpack. You could reach out to the folks that maintain it. We do have a [sample v3 buildpack for...

What webdriver are you using with Safari?

Hi @johanbrandhorst, thanks for contributing. Your PR looks fantastic! If you have time, you could add an integration test [here](https://github.com/sclevine/agouti/blob/master/internal/integration/selection_test.go) that looks like [this](https://github.com/sclevine/agouti/blob/master/internal/integration/page_test.go#L66). Doing so would give us a...

As a general rule, Agouti should implement the w3c spec, and bugs and missing functionality should be fixed upstream in the webdrivers. At the `agouti` package level, this is achieved...

Almost. The `agouti/api` package has a single responsibility -- implement the w3c spec verbatim. So for the fallback, your `agouti.Selection.Screenshot` method should call `api.Session.GetScreenshot` and do the cropping at the...

With the exception of tests (which depend on Ginkgo) and the Gomega `matchers` package (which depends on Gomega), Agouti has no third party dependencies. Given that `cutter` just seems to...