Samuel Cormier-Iijima
Samuel Cormier-Iijima
@charliermarsh this should be good to go. Apologies for the large/difficult-to-review PR, but if you want to check my work, the 3rd and 4th commits (which are the largest) were...
Not to weigh in one way or another, but just a note that black will rewrite the first example as the second.
@clbarnes yes, the PR as it stands should support deserializing from `{"type": "OptionalAttrs"}`. I'm not sure if this code still works as-is with the latest changes in `main`. Maybe @dtolnay...
@jaraco sure. Not sure why the tests would have started failing after, but this patch fixes the tests for me: ```patch diff --git a/distutils/sysconfig.py b/distutils/sysconfig.py index bc579163..4e1cd3ac 100644 --- a/distutils/sysconfig.py...
@jaraco yes I'm not sure how that would have worked before, but in any case it's probably easiest to change it like this: ```patch diff --git a/distutils/sysconfig.py b/distutils/sysconfig.py index 4e1cd3ac..937482a4...
More test failures? ðŸ˜
Any thougths on the remaining failing test? I'll try to take a look but won't have much time.
Seems that's what the upstream patch does as well. This was probably a mistake on my end when I was updating it. Nice catch!
Actually, I think the new error in `test_customize_compiler` is what I was attempting to fix by setting it to `""`.
This fix is not quite complete since in the newer version of Celery the task won't get registered by default. I think converting it to a `shared_task` is the correct...