Samuel Cormier-Iijima

Results 72 comments of Samuel Cormier-Iijima

I believe that this does work if you use `Option`. However it would be nice if this worked automatically if the variant has a `Default`.

~My suggestion is to mimic the [behavior Python takes in PEP 495](https://peps.python.org/pep-0495/#mind-the-gap), which is to change `None` to instead be `Gap(T, T)` or `Invalid(T, T)`, where the earliest and latest...

Any word on this? Can that commit be reverted until a better fix is found?

In case it helps debugging - this seems to have broken in @swc/[email protected]. @swc/[email protected] does not exhibit the bug.

I was considering updating the README with something to that effect. Perhaps not replacing everything in the documentation, but at least adding a blurb to the top explaining why this...

Disclosure: I bring this question up because of a specific security-related check I'd be interested in seeing in Ruff that we've been using in our own codebase via a custom...

Two other thoughts/questions that came to mind along similar lines: - Should Ruff include checks for compatibility with versions of Python that are unsupported by Ruff itself? (Per [this comment](https://github.com/charliermarsh/ruff/issues/2096#issuecomment-1399652963),...

Could be fixed for this example by skipping `Attribute`s in the B020 name finder, but I would argue that this iteration pattern is unclear and would warrant a linter warning....

Rather than looking for a specific shebang, maybe a configuration could be added to include certain files based on paths?

Another simple workaround would be to find the files separately and pass those explicitly to ruff, e.g. (with ripgrep): ``` rg -l -0 '\A#!/usr/bin/env python' | xargs -0 ruff ```