ScientificWare
ScientificWare
@SWinxy Thanks for comments. ~~After reading them, I realize the Big Mistake !~~ ~~I Shouldn't create a new object but rather return an existing one.~~ ~~That was in my intention....
@SWinxy > I'd be interested to know the perf results when the behavior is unchanged, and if the enhanced switch would win out. The results are also in my repository,...
Yes @SWinxy, you're right. Map and TreeMap implementations return the same object. Therefore comparisons with the current implemention or switch case solution are not relevant. I going to add a...
@SWinxy All my apologies, I skipped testing CASE + RGB implementation. I posted it but not tested (previous results were about CASE + Hex. I updated my table including your...
@SWinxy Thanks for your reviews and confirmation tests. Do you notice that the `switch ... case` is also two times slower than my "handmade" binary tree using `if ... else`...
@aivanov-jdk I complete my first answer to try to release your objection : - there is no CSS Level 4. CSS is no more a monolithic specification. It's a set...
1. > Should it be an enhancement? This PR - corrects or changes `Orange` value in (bug ?) - adds new values + improve performance (enhancements) So I think it's...
> Are you talking about https://github.com/openjdk/jdk/pull/9825#issuecomment-1216011827? @SWinxy Yes, only because the result is publicly exposed : `stringToColor` is also used by `javax.swing.text.html.StyleSheet stringToColor` method to publicly return the `Color` Object....
> Shall I edit the subject of the issue to be more specific? “Add named colors from CSS Color Module Level 4”? Yes, you may. Thanks. > ... please create...
> I said, I would submit a CSR for you after we agree on the updated javadoc for StyleSheet.stringToColor. Sorry, I didn't realize the message was from the bot. "JDK-8293776...