Marco Schumacher

Results 53 comments of Marco Schumacher

Fair enough. Thanks for looking into it.

Fair enough. I think the performance might not too bad in comparison. BuildKit builds are usually run in a container anyway, as far as I know - but my knowledge...

@cristianrgreco when you have a minute, could you give feedback?

Ok, completely new development: As @mikeseese pointed out (https://github.com/testcontainers/testcontainers-node/issues/571#issuecomment-2159657555), the version flag is in fact working. Upon investigation I found that I can make it work from testcontainers as well...

A simple manual way to reproduce it is to run `docker image rm node:10-alpine`, them execute just that test case: `npm run test -- packages/testcontainers/src/generic-container/generic-container-dockerfile.test.ts -t "buildKit"`. It will fail....

@apocas @grpc/grpc-js is updated now. Accepting the docker-modem PR would be in your hands. Anything unclear there? Besides that, the random errors remain. Do you have any idea what could...

> @schummar Did you happen to release this anywhere? No, not yet. I've been experimenting with my own library — maybe something will come of it. Let's see.

I don't think that's right. Passing `{ version: "2" }` to dockerode's `buildImage` doesn't do anything. The build still fails when using some BuildKit dependent feature like `--mount=type=cache`. I quickly...

> @schummar I guess my verification was that prior to adding `{ version: "2" }` to the build options object, I would receive the error during building my image: >...

Yeah, that's what I also found in #761. And that's also what stopped all my past experiments, because due to a bug (#771) `pull: 'true'` is currently always sent in...