Marco Schumacher

Results 32 comments of Marco Schumacher

> 1 failed sir @schummar Unfortunately, there seem to be some very flaky tests, so I almost always see some error or another when running these tests. I look at...

@keithkirton as I said before, I don't think that the tests are broken because of this PR. Rerunning them might be enough. There are also merge conflicts again, but I...

I don't think @logixode is part of the Vite team, he just made a review as anyone can 😉 Mentioning team members is probably not the right thing to do....

@niik thanks for the reply. I didn't expect this to be quick. Of course this is a big decision and will take time, no worries. I made the Pull Request...

> Your point about using a specific git version makes sense. I see no issue with using an embedded git version also for WSL as well. I'll try to include...

A little script for anyone who wants to try it out: ```bash git clone https://github.com/schummar/dugite.git git clone https://github.com/schummar/desktop.git cd dugite git checkout origin/feature/wslGit yarn yarn build yarn link cd ../desktop...

It seems that problem has been discussed a lot already in other issues quite a bit, so it's probably not connected to the WSL integration. See https://github.com/desktop/desktop/issues/10345#issuecomment-673053479. But if you...

> what do we need to have this in the master branch? it's impossible to use github for desktop with a repo in WSL I am currently waiting for feedback...

In Windows Terminal.

> I haven't looked at the details of this PR, but a good implementation for similar thing is to look at vscode. Actual vscode logic remains with vscode-server, and it's...