Martin Schreiber

@arporter 1. I worked on the code coverage. Let's see what the next push brings. 2. There was something in the code that I didn't understand: `async_queue` was never to...

> @arporter > > 1. I worked on the code coverage. Let's see what the next push brings. > > 2. There was something in the code that I didn't...

This pull request (currently under review by Andy) https://github.com/stfc/PSyclone/pull/2775 will provide the subroutine `get_argument_routine_match(...)` which returns a list of the indices of the matching arguments from a call to a...

**kwargs don't trigger the error at the place that caused it. The apply() function is called, but the arguments are then forwarded to the validate function where the error would...

I realized this in a PR as a dedicated `set_option` call: https://github.com/stfc/PSyclone/blob/martin_2_issue_inline_optional_args_2525/src/psyclone/psyir/transformations/inline_trans.py#L164 This provides a clear **separation** between **setting the options and applying the transformation**. These options are then **stored...

PS: The other reason I use a dedicated `set_option` is that this allows setting the options once, and then reapplying this transformation with the same options repeatedly.

Thanks for sharing this code snippet. Cons about your example above: - If you pass the options like in the example above, a typo in these options will never be...

> One advantage of explicit keyword argument lists is that a default is clear - at the moment, defaults are obtained by: dict.get("keyword", False) or similar, but we now just...

My fault. I thought you were describing the `option` dict as an argument. Don't we also need options to `validate`? For example, I'd like to call `validate(options)` to see whether...

Just determining all dependencies has already been implemented by @hiker and I propose a "reduced" version of this in a future PR: https://github.com/stfc/PSyclone/blob/martin_nemo_call_trace/src/psyclone/parse/module_manager_base.py This class is then inherited by another...