Moshe Schorr
Moshe Schorr
> ```python3 > # Technically legal > cols = [col.replace('*', '').replace('#', '') for col in cols] > > # More readable in my opinion > cols = [ > col.replace('*',...
Re the other guidelines: - I like general use of type annotations in function signatures. - I think we should use f-strings where possible (though not necessarily backport everything to...
This line is 103 chars. I think it is a good example of being clean as-is ```python3 mlb_only_cols = ['key_retro', 'key_bbref', 'key_fangraphs', 'mlb_played_first', 'mlb_played_last'] ```
If we do have one -- how would we use the file thingy? yapf sounds like the normal answer, yet seems perennially broken on VSCode
I mean my VSCode yapf is always broken
Maybe blue if they do a CI - we've been single quotes until this point.
is there a data source for this?
That B-Ref link looks pretty similar to the Lahman format -- it shouldn't be hard to do that based on the existing functions to scrape B-Ref tables
I don't see a need to standardize. People contribute in their free time, it shouldn't be too hard. So long as the docstrings are understandable, I'm happy with it.
We already have a slack chat, we could do that there or on Discord I guess. Is there a preference for Slack or Discord here?