Roger Schönbächler

Results 13 comments of Roger Schönbächler

As for the tests: I do manual tests. This is something I've wanted to improve for a long time, but never got around to it. I think the use of...

Yes, that would be great. Let me know when I can review it.

Thank you for your work so far. I very much appreciate your efforts to improve this library and I like that you bring a different perspective into it. I like...

I wouldn't switch the parameters. Even a small breaking change is a breaking change and requires (in this case all) users to change their implementation. My intention is to have...

Another way of dealing with this is to just publish a v4 beta or next version on npm. That way we don't have to rush out a backwards compatible release...

I can understand your trauma 😄 But I would like to still follow the principles from PDFKit. Take a look at the [linearGradient](https://pdfkit.org/docs/vector.html#gradients): ```ts // Create a linear gradient let...

> every time I want to add a QR Bill to a PDF, I have to modify the class to make it work with all my other functions. Can you...

You are right, we don't need to extend both classes. So yes, go ahead and implement this. I like such improvements.

I'm also sorry for the delay @danielpanero. I did a quick review and I'm not sure if we should remove the overloads completely and just provide an API with streams....

@fivdi I have included all the necessary functions as I was working on the wave functions. Because I need the serial functions in some projects on a Raspberry Pi 3B+,...